rust-lang / rust-lang/rust-analyzer

alternative to postfix `ifl` completion that matches `Err` for `Result`

Open
#21,440 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-feature
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

Currently we have ifl as a way to expand <expr of type Result<_,_>>.ifl to

if let Ok(<cursor>) = <expr of type Result<_,_>> {

}

But I find myself regular wanting to match on Err rather than Ok.

i.e. have e.g. ifle that expands <expr of type Result<_,_>>.ifle to

if let Err(<cursor>) = <expr of type Result<_,_>> {

}

Alternatively to adding a new postfix expansion keyword if possible the ifl could also ask for which variant one wants to match on instead of assuming Ok for Result.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the postfix completion implementation for the existing ifl expansion in rust-analyzer. Compare the current Result/Ok behavior with the requested Err variant, then verify that either an ifle expansion or variant-selection prompt produces the expected Rust snippet.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.