rust-lang / rust-lang/rust-analyzer

Upcoming rustc changes in capture analysis of pattern matching

Open
#21,274 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-layout
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

Hello, CI on rust-lang/rust#138961 has picked up a rust-analyzer test that fails with the rustc changes applied – specifically ones that assert that r-a gets the same size of closures as rustc, see this comment for details.

Should we comment these tests out for now? What's your take on this?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the rust-analyzer test reported by CI on rust-lang/rust#138961 and read the linked comment about closure-size assertions. Compare the affected capture-analysis behavior with rustc, then determine whether the tests should be adjusted or temporarily disabled; done means the agreed behavior is reflected and CI passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.