rust-lang / rust-lang/rust-analyzer
"Convert `as X` to `X::from`" assist
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
It would be useful if rust-analyzer had an assist that allows quickly changing an as x cast to an x::from-style cast (when the appropriate From impl exists). This would save a bunch of typing when refactoring casts to be more precise (since as _ will wrap).
Additionally, it could also offer a conversion to .try_into().unwrap() when there is only a TryFrom/TryInto impl but no From/Into impl, since that's a common change too.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating rust-analyzer's assist implementations and tests for cast-related assists, then inspect how available From/TryFrom implementations are checked. Done means an assist converts eligible as casts to X::from and offers .try_into().unwrap() when only a fallible conversion is available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100