rust-lang / rust-lang/rust-analyzer

syntax-editor: Split concept of node identity from SyntaxNode equality

Open
#21,155 0 comments 2 reactions 1 assignee View on GitHub

@DropDemBits is already working on this.

Since Nov 28, 2025.

C-cleanup
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

SyntaxEditor relies on the notion of SyntaxNode equality to track a node through the whole SyntaxMapping tree, but identity is unfortunately currently tied to SyntaxNodes being reference counted. We can add a layer of indirection (e.g. SyntaxId) so that we can associate multiple node instances with the same identity and further separate ourselves from the concept of mutable syntax trees.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.