rust-lang / rust-lang/rust-analyzer
Prefer to import through `super` when already used in module
Open
Nobody has claimed this yet.
C-bug
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
r-a can suggest fixes of the form "import crate::Foo".
Where an existing use super::Blah item already appears in the module and Foo is declared in super, r-a should prefer to import super::Foo instead (for consistency with existing code).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the import-fix logic that suggests crate::Foo and inspect how existing use super::Blah items are detected. Reproduce the case described in the issue, then add coverage for preferring super::Foo when Foo is declared in super; done means the suggestion is consistent while other imports remain unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100