rust-lang / rust-lang/rust-analyzer
Recomputing TargetDataLayout from the string is incorrect
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
The actual computation we want to do will require additional information from the Target. We need to enrich it with enough information to make it actually useful to Rust. I will probably be making it impossible to use the string parsing as an entry point into that type.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating TargetDataLayout and the string-parsing entry point mentioned in the issue, then inspect how target information is currently computed. Determine what additional Target information Rust requires and how the type should be enriched. Done means the computation no longer relies incorrectly on reparsing the string and the intended new entry point is established.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100