rust-lang / rust-lang/rust-analyzer
More glob import issues
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
Condvar in https://github.com/salsa-rs/salsa/blob/f78a641d2086695ac0ef96cbe915bf80b5a690f2/src/storage.rs#L5 is being resolved to std's condvar which is incorrect, it should resolve to https://github.com/salsa-rs/salsa/blob/f78a641d2086695ac0ef96cbe915bf80b5a690f2/src/loom.rs#L214 instead. That is the pub use std::sync::*; glob import there is shadowing the definition incorrectly.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/storage.rs at line 5 and compare the Condvar resolution with the definition and glob export around src/loom.rs line 214. Trace the glob-import resolution behavior and run the relevant name-resolution tests. Done means Condvar resolves to the loom definition rather than std's Condvar, with a regression test covering the case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers, devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100