rust-lang / rust-lang/rust-analyzer
"Try wrapping the expression" action wraps in all viable types
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
rust-analyzer version: rust-analyzer 1.84.0 (9fc6b43 2025-01-07)
rustc version: rustc 1.84.0 (9fc6b4312 2025-01-07)
editor or extension: helix 25.01.1 (7275b7f8)
relevant settings: None?
code snippet to reproduce:
enum Thing {
Foo(String),
Bar(String),
}
fn thing() -> Thing {
String::new()
}
rust-analyzer suggests:
mismatched types
expected `Thing`, found `String`
try wrapping the expression in a variant of `Thing`: `Thing::Foo(`, `)`, `Thing::Bar(`, `)`
Taking this action results in:
enum Thing {
Foo(String),
Bar(String),
}
fn thing() -> Thing {
Thing::Foo(Thing::Bar(String::new()))
}
Should "Wrap in Thing::Foo" and "Wrap in Thing::Bar" be separate actions?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the diagnostic with the Rust enum and function shown in the issue, then trace rust-analyzer’s code-action generation for “try wrapping the expression.” Done means the available actions independently wrap the expression in Thing::Foo and Thing::Bar without nesting one variant inside another; add focused coverage for the reproduced case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- developer-experience
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100