rust-lang / rust-lang/rust-analyzer
Usage of `Idx` without its containing `Arena` context might be a footgun
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
Recently, I stepped on this in #19182 but I've been feeling fearness of such "local id" things for a while, like in #17882 (in that case, the bound var index is a "local id")
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the related issues #19182 and #17882, then trace the Idx and Arena usage they discuss. The issue does not name files, tests, or a specific change; it is done only once the desired handling of these local IDs and their containing context has been agreed and documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100