rust-lang / rust-lang/rust-analyzer
Diagnostics are called twice
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
Once for assists (quickfixes) and the other for diagnostics.
We can fix this locally by caching the diagnostics of the last file, or globally by making diagnostics queries. I believe a global solution is required anyway, since we want to run diagnostics for the whole workspace (perhaps only on save) eventually.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how diagnostics are requested for assists and for the diagnostics view. Compare the proposed per-file cache with a global diagnostics-query design, keeping the future whole-workspace and on-save requirements in scope. Done means the same diagnostics are not computed twice and the chosen approach supports those stated requirements.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100