rust-lang / rust-lang/rust-analyzer
Renaming a field used in thiserror won't rename the usage in the attribute of the macro (I think it may be related to the serde(with))
Open
Nobody has claimed this yet.
A-ide
A-proc-macro
C-bug
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
use std::io;
use thiserror::Error;
#[derive(Error, Debug)]
#[error("Rename failed at {}", .source)]
pub struct Error {
// renaming this field won't rename the usage above
source: io::Error,
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reproduction in the issue and investigate rust-analyzer's rename handling for the thiserror #[error] attribute, comparing it with the mentioned serde(with) behavior. Done means renaming the source field also updates its usage in the attribute without breaking the generated error implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100