rust-lang / rust-lang/rust-analyzer
Respect `clippy::unused-trait-names` when auto-importing traits
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
IMO, Traits should be auto-imported as _ if https://rust-lang.github.io/rust-clippy/master/index.html#unused_trait_names is enabled and I'm not actively trying to import the trait name. I'm not entirely sure whether changing behavior depending on clippy configuration is in scope, though, or whether this behavior is better implemented on the editor side of things.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing rust-analyzer's auto-import handling for traits and determine how Clippy configuration is exposed to that path. Compare the current behavior with the unused_trait_names lint and resolve whether the change belongs in rust-analyzer or the editor. Done means the intended behavior and ownership are established, with coverage for the selected approach.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- developer-experience, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100