rust-lang / rust-lang/rust-analyzer

Generate additional function parameters from function call

Open
#18,576 8 comments 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-assists C-feature
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

let's say we have the following code:

fn foo(x: i32) { ... }

I now want to add a second argument and add the parameter to the signature automatically, via assist.

foo(5, "bar");

resulting in this:

fn foo(x: i32, arg: &str) { ... }

This is somewhat similar to the assist to generate a new function based on a function call, but instead updating the signature of an existing function.
This would be especially useful when using more complex types that can be inferred.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from the existing assist that generates a new function from a function call, then trace how it identifies the called function and inferred argument types. Add the corresponding behavior for an existing function signature, and run the relevant assist tests to verify that the new parameter and type are generated correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.