codeAction/resolve throws an exception for a code action without `data`

rust-analyzer version: rust-analyzer 1.84.0-nightly (df4ca44 2024-10-27)

rustc version: rustc 1.84.0-nightly (df4ca44d3 2024-10-27)

editor or extension: Vim/YouCompleteMe

relevant settings: All settings left at default values.

repository link (if public, optional): N/A

code snippet to reproduce:

fn main() {
    let a = 5;
}

Log of messages exchanged between YCM and rust-analyzer:

2024-10-28 18:01:43,339 - DEBUG - TX: Sending message: b'Content-Length: 2283\r\n\r\n{"id":1,"jsonrpc":"2.0","method":"initialize","params":{"capabilities":{"experimental":{"serverStatusNotification":true,"statusNotification":true},"textDocument":{"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["","quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports","source.fixAll"]}},"dataSupport":true,"resolveSupport":{"properties":["edit","command"]}},"completion":{"completionItem":{"documentationFormat":["plaintext","markdown"],"resolveSupport":{"properties":["documentation","detail"]}},"completionItemKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25]}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":false,"labelSupport":false,"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]}},"hover":{"contentFormat":["plaintext","markdown"]},"inlay_hint":{},"semanticTokens":{"augmentSyntaxTokens":true,"formats":["relative"],"requests":{"full":{"delta":false},"range":true},"tokenModifiers":[],"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","member","macro","keyword","modifier","comment","string","number","regexp","operator"]},"signatureHelp":{"signatureInformation":{"documentationFormat":["plaintext","markdown"],"parameterInformation":{"labelOffsetSupport":true}}},"synchronization":{"didSave":true}},"workspace":{"applyEdit":true,"configuration":true,"didChangeWatchedFiles":{"dynamicRegistration":true},"symbol":{"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]}},"workspaceEdit":{"documentChanges":true,"failureHandling":"abort","resourceOperations":["create","rename","delete"]},"workspaceFolders":true}},"initializationOptions":{},"processId":17292,"rootPath":"/home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common","rootUri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common","workspaceFolders":[{"name":"common","uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common"}]}}'
2024-10-28 18:01:43,352 - DEBUG - RX: Received message: b'{"jsonrpc":"2.0","id":1,"result":{"capabilities":{"positionEncoding":"utf-16","textDocumentSync":{"openClose":true,"change":2,"save":{}},"selectionRangeProvider":true,"hoverProvider":true,"completionProvider":{"triggerCharacters":[":",".","\'","("],"completionItem":{"labelDetailsSupport":false}},"signatureHelpProvider":{"triggerCharacters":["(",",","<"]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"workspaceSymbolProvider":true,"codeActionProvider":{"codeActionKinds":["","quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite"],"resolveProvider":true},"codeLensProvider":{"resolveProvider":true},"documentFormattingProvider":true,"documentRangeFormattingProvider":false,"documentOnTypeFormattingProvider":{"firstTriggerCharacter":"=","moreTriggerCharacter":[".",">","{","("]},"renameProvider":{"prepareProvider":true},"foldingRangeProvider":true,"declarationProvider":true,"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":true},"fileOperations":{"willRename":{"filters":[{"scheme":"file","pattern":{"glob":"**/*.rs","matches":"file"}},{"scheme":"file","pattern":{"glob":"**","matches":"folder"}}]}}},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["comment","decorator","enumMember","enum","function","interface","keyword","macro","method","namespace","number","operator","parameter","property","string","struct","typeParameter","variable","angle","arithmetic","attributeBracket","attribute","bitwise","boolean","brace","bracket","builtinAttribute","builtinType","character","colon","comma","comparison","constParameter","const","deriveHelper","derive","dot","escapeSequence","formatSpecifier","generic","invalidEscapeSequence","label","lifetime","logical","macroBang","parenthesis","procMacro","punctuation","selfKeyword","selfTypeKeyword","semicolon","static","toolModule","typeAlias","union","unresolvedReference"],"tokenModifiers":["async","documentation","declaration","static","defaultLibrary","associated","attribute","callable","constant","consuming","controlFlow","crateRoot","injected","intraDocLink","library","macro","mutable","procMacro","public","reference","trait","unsafe"]},"range":true,"full":{"delta":true}},"inlayHintProvider":{"resolveProvider":true},"experimental":{"externalDocs":true,"hoverRange":true,"joinLines":true,"matchingBrace":true,"moveItem":true,"onEnter":true,"openCargoToml":true,"parentModule":true,"runnables":{"kinds":["cargo"]},"ssr":true,"workspaceSymbolScopeKindFiltering":true}},"serverInfo":{"name":"rust-analyzer","version":"1.84.0-nightly (df4ca44 2024-10-27)"}}}'
2024-10-28 18:01:43,353 - DEBUG - TX: Sending notification: b'Content-Length: 52\r\n\r\n{"jsonrpc":"2.0","method":"initialized","params":{}}'
2024-10-28 18:01:43,353 - DEBUG - TX: Sending notification: b'Content-Length: 86\r\n\r\n{"jsonrpc":"2.0","method":"workspace/didChangeConfiguration","params":{"settings":{}}}'
2024-10-28 18:01:43,354 - DEBUG - TX: Sending notification: b'Content-Length: 280\r\n\r\n{"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"languageId":"rust","text":"fn main() {\\n    let a = 5;\\n}\\n","uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs","version":1}}}'
2024-10-28 18:01:43,355 - DEBUG - RX: Received message: b'{"jsonrpc":"2.0","method":"experimental/serverStatus","params":{"health":"ok","quiescent":false,"message":null}}'
2024-10-28 18:01:43,355 - DEBUG - RX: Received message: b'{"jsonrpc":"2.0","id":0,"method":"workspace/configuration","params":{"items":[{"section":"rust-analyzer"}]}}'
2024-10-28 18:01:43,355 - DEBUG - TX: Sending response: b'Content-Length: 40\r\n\r\n{"id":0,"jsonrpc":"2.0","result":[null]}'
2024-10-28 18:01:43,633 - DEBUG - RX: Received message: b'{"jsonrpc":"2.0","id":1,"method":"client/registerCapability","params":{"registrations":[{"id":"workspace/didChangeWatchedFiles","method":"workspace/didChangeWatchedFiles","registerOptions":{"watchers":[{"globPattern":"/home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/**/*.rs"},{"globPattern":"/home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/**/Cargo.{toml,lock}"},{"globPattern":"/home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/**/rust-analyzer.toml"},{"globPattern":"/home/bstaletic/.config/rust-analyzer/rust-analyzer.toml"},{"globPattern":"/home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/Cargo.toml"}]}}]}}'
2024-10-28 18:01:43,637 - DEBUG - TX: Sending response: b'Content-Length: 38\r\n\r\n{"id":1,"jsonrpc":"2.0","result":null}'
2024-10-28 18:01:43,908 - DEBUG - RX: Received message: b'{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs","diagnostics":[],"version":1}}'
2024-10-28 18:01:43,908 - DEBUG - RX: Received message: b'{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs","diagnostics":[],"version":1}}'
2024-10-28 18:01:43,973 - DEBUG - RX: Received message: b'{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs","diagnostics":[{"range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}},"severity":2,"code":"unused_variables","source":"rustc","message":"unused variable: `a`\\n`#[warn(unused_variables)]` on by default","relatedInformation":[{"location":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs","range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}}},"message":"if this is intentional, prefix it with an underscore: `_a`"}],"tags":[1],"data":{"rendered":"warning: unused variable: `a`\\n --> src/main.rs:2:9\\n  |\\n2 |     let a = 5;\\n  |         ^ help: if this is intentional, prefix it with an underscore: `_a`\\n  |\\n  = note: `#[warn(unused_variables)]` on by default\\n\\n"}},{"range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}},"severity":4,"code":"unused_variables","source":"rustc","message":"if this is intentional, prefix it with an underscore: `_a`","relatedInformation":[{"location":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs","range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}}},"message":"original diagnostic"}]}],"version":1}}'
2024-10-28 18:01:44,275 - DEBUG - RX: Received message: b'{"jsonrpc":"2.0","id":2,"method":"client/registerCapability","params":{"registrations":[{"id":"workspace/didChangeWatchedFiles","method":"workspace/didChangeWatchedFiles","registerOptions":{"watchers":[{"globPattern":"/home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/**/*.rs"},{"globPattern":"/home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/**/Cargo.{toml,lock}"},{"globPattern":"/home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/**/rust-analyzer.toml"},{"globPattern":"/home/bstaletic/.config/rust-analyzer/rust-analyzer.toml"},{"globPattern":"/home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/Cargo.toml"}]}}]}}'
2024-10-28 18:01:44,290 - DEBUG - TX: Sending response: b'Content-Length: 38\r\n\r\n{"id":2,"jsonrpc":"2.0","result":null}'
2024-10-28 18:01:44,291 - DEBUG - RX: Received message: b'{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs","diagnostics":[{"range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}},"severity":2,"code":"unused_variables","source":"rustc","message":"unused variable: `a`\\n`#[warn(unused_variables)]` on by default","relatedInformation":[{"location":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs","range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}}},"message":"if this is intentional, prefix it with an underscore: `_a`"}],"tags":[1],"data":{"rendered":"warning: unused variable: `a`\\n --> src/main.rs:2:9\\n  |\\n2 |     let a = 5;\\n  |         ^ help: if this is intentional, prefix it with an underscore: `_a`\\n  |\\n  = note: `#[warn(unused_variables)]` on by default\\n\\n"}},{"range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}},"severity":4,"code":"unused_variables","source":"rustc","message":"if this is intentional, prefix it with an underscore: `_a`","relatedInformation":[{"location":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs","range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}}},"message":"original diagnostic"}]}],"version":1}}'
2024-10-28 18:01:50,598 - DEBUG - RX: Received message: b'{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs","diagnostics":[{"range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}},"severity":2,"code":"unused_variables","source":"rustc","message":"unused variable: `a`\\n`#[warn(unused_variables)]` on by default","relatedInformation":[{"location":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs","range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}}},"message":"if this is intentional, prefix it with an underscore: `_a`"}],"tags":[1],"data":{"rendered":"warning: unused variable: `a`\\n --> src/main.rs:2:9\\n  |\\n2 |     let a = 5;\\n  |         ^ help: if this is intentional, prefix it with an underscore: `_a`\\n  |\\n  = note: `#[warn(unused_variables)]` on by default\\n\\n"}},{"range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}},"severity":4,"code":"unused_variables","source":"rustc","message":"if this is intentional, prefix it with an underscore: `_a`","relatedInformation":[{"location":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs","range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}}},"message":"original diagnostic"}]}],"version":1}}'
2024-10-28 18:01:50,599 - DEBUG - RX: Received message: b'{"jsonrpc":"2.0","method":"experimental/serverStatus","params":{"health":"ok","quiescent":true,"message":null}}'
2024-10-28 18:01:57,222 - DEBUG - TX: Sending message: b'Content-Length: 1566\r\n\r\n{"id":2,"jsonrpc":"2.0","method":"textDocument/codeAction","params":{"context":{"diagnostics":[{"code":"unused_variables","data":{"rendered":"warning: unused variable: `a`\\n --> src/main.rs:2:9\\n  |\\n2 |     let a = 5;\\n  |         ^ help: if this is intentional, prefix it with an underscore: `_a`\\n  |\\n  = note: `#[warn(unused_variables)]` on by default\\n\\n"},"message":"unused variable: `a`\\n`#[warn(unused_variables)]` on by default","range":{"end":{"character":9,"line":1},"start":{"character":8,"line":1}},"relatedInformation":[{"location":{"range":{"end":{"character":9,"line":1},"start":{"character":8,"line":1}},"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs"},"message":"if this is intentional, prefix it with an underscore: `_a`"}],"severity":2,"source":"rustc","tags":[1]},{"code":"unused_variables","message":"if this is intentional, prefix it with an underscore: `_a`","range":{"end":{"character":9,"line":1},"start":{"character":8,"line":1}},"relatedInformation":[{"location":{"range":{"end":{"character":9,"line":1},"start":{"character":8,"line":1}},"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs"},"message":"original diagnostic"}],"severity":4,"source":"rustc"}]},"range":{"end":{"character":8,"line":1},"start":{"character":8,"line":1}},"textDocument":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs"}}}'
2024-10-28 18:01:57,393 - DEBUG - RX: Received message: b'{"jsonrpc":"2.0","id":2,"result":[{"title":"Insert explicit type `i32`","kind":"refactor.rewrite","data":{"codeActionParams":{"textDocument":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs"},"range":{"start":{"line":1,"character":8},"end":{"line":1,"character":8}},"context":{"diagnostics":[{"range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}},"severity":2,"code":"unused_variables","source":"rustc","message":"unused variable: `a`\\n`#[warn(unused_variables)]` on by default","relatedInformation":[{"location":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs","range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}}},"message":"if this is intentional, prefix it with an underscore: `_a`"}],"tags":[1],"data":{"rendered":"warning: unused variable: `a`\\n --> src/main.rs:2:9\\n  |\\n2 |     let a = 5;\\n  |         ^ help: if this is intentional, prefix it with an underscore: `_a`\\n  |\\n  = note: `#[warn(unused_variables)]` on by default\\n\\n"}},{"range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}},"severity":4,"code":"unused_variables","source":"rustc","message":"if this is intentional, prefix it with an underscore: `_a`","relatedInformation":[{"location":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs","range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}}},"message":"original diagnostic"}]}]}},"id":"add_explicit_type:RefactorRewrite:0","version":1}},{"title":"Promote local to constant","kind":"refactor","data":{"codeActionParams":{"textDocument":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs"},"range":{"start":{"line":1,"character":8},"end":{"line":1,"character":8}},"context":{"diagnostics":[{"range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}},"severity":2,"code":"unused_variables","source":"rustc","message":"unused variable: `a`\\n`#[warn(unused_variables)]` on by default","relatedInformation":[{"location":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs","range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}}},"message":"if this is intentional, prefix it with an underscore: `_a`"}],"tags":[1],"data":{"rendered":"warning: unused variable: `a`\\n --> src/main.rs:2:9\\n  |\\n2 |     let a = 5;\\n  |         ^ help: if this is intentional, prefix it with an underscore: `_a`\\n  |\\n  = note: `#[warn(unused_variables)]` on by default\\n\\n"}},{"range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}},"severity":4,"code":"unused_variables","source":"rustc","message":"if this is intentional, prefix it with an underscore: `_a`","relatedInformation":[{"location":{"uri":"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs","range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}}},"message":"original diagnostic"}]}]}},"id":"promote_local_to_const:Refactor:1","version":1}},{"title":"if this is intentional, prefix it with an underscore: `_a`","kind":"quickfix","edit":{"changes":{"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs":[{"range":{"start":{"line":1,"character":8},"end":{"line":1,"character":9}},"newText":"_a"}]}},"isPreferred":false}]}'
2024-10-28 18:01:58,812 - DEBUG - TX: Sending message: b'Content-Length: 409\r\n\r\n{"id":3,"jsonrpc":"2.0","method":"codeAction/resolve","params":{"edit":{"changes":{"file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs":[{"newText":"_a","range":{"end":{"character":9,"line":1},"start":{"character":8,"line":1}}}]}},"isPreferred":false,"kind":"quickfix","title":"if this is intentional, prefix it with an underscore: `_a`"}}'
2024-10-28 18:01:58,813 - DEBUG - RX: Received message: b'{"jsonrpc":"2.0","id":3,"error":{"code":-32602,"message":"code action without data"}}'

The client supports codeAction/resolve, can resolve edit and/or command and will preserver data if any.
If I'm reading the specification correctly, that means that if either of edit or command is missing and regardless of the existence of data, the client should try to resolve the code action.
Rust-analyzer will return an error if there is no data.

From the above log of messages:

1. The user requests code actions for line 1, character 8 (0-based).
2. User then chooses the last option:

{
  "title": "if this is intentional, prefix it with an underscore: `_a`",
  "kind": "quickfix",
  "edit": {
    "changes": {
      "file:///home/bstaletic/.vim/pack/bundle/start/YouCompleteMe/third_party/ycmd/ycmd/tests/rust/testdata/common/src/main.rs": [
        {
          "range": {
            "start": {
              "line": 1,
              "character": 8
            },
            "end": {
              "line": 1,
              "character": 9
            }
          },
          "newText": "_a"
        }
      ]
    }
  },
  "isPreferred": false
}

3. My client tries to resolve it, because command is missing.
4. R-A then returns an error.

On a side note, that title is a little odd.

Start by reproducing the reported codeAction/resolve request with the provided Rust snippet and inspect the rust-analyzer handling of code actions whose data field is absent. Done means resolving such a code action no longer throws an exception; add or run a regression test if the relevant test entry point is found.