rust-lang / rust-lang/rust-analyzer

Incorrect elided lifetime shown

Open
#18,094 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-inlay-hints A-lifetimes C-bug
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

rust-analyzer version: 0.3.2104-standalone (08c7bbc2d 2024-09-06)

rustc version: rustc 1.81.0 (eeb90cda1 2024-09-04)

editor or extension: VsCode, with rust-analyzer extension version v0.3.2104

relevant settings:

{
    "rust-analyzer.inlayHints.genericParameterHints.lifetime.enable": true,
    "rust-analyzer.inlayHints.lifetimeElisionHints.enable": "always",
}

code snippet to reproduce:

pub struct FooRef<'a>(pub &'a i32);

pub struct Foo(i32);

impl Foo {
    pub fn foo_as_ref(&self) -> FooRef<'_> {
        FooRef(&self.0)
    }
}
image

The elided lifetime for self and for FooRef should be shown as the same lifetime in the inlay hint. However, they're shown as different lifetimes.

Discovered by tionway on the rust community discord.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the provided Rust snippet with lifetime elision hints enabled using the listed rust-analyzer settings. Compare the inlay hints for the elided lifetime on &self and FooRef<'_>; done means both display the same lifetime without changing unrelated hints.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.