rust-lang / rust-lang/rust-analyzer
Rethink `hir-def` and `hir-expand`
Open
Nobody has claimed this yet.
A-macro
A-nameres
C-Architecture
C-enhancement
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
https://github.com/rust-lang/rust-analyzer/pull/17936 shows that some macros can in fact depend on the module hierarchy (in fact, include does too but we managed to get around that by luck it seems), so while the split makes sense, something here feels wrong.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading PR #17936 and the issue's discussion of the hir-def and hir-expand split. Determine how module-hierarchy-dependent macros, including include, should be represented and define a clear design for the revised boundary; the work is done when that design is agreed and the affected behavior is covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers, tooling
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100