rust-lang / rust-lang/rust-analyzer
Move some of the macro expansion tests / add some standalone ones to hir-expand
@bit-aloo is already working on this.
Since Mar 28, 2025.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
Currently all of them live in the hir-def crate, making use of nameresolution, but I believe we should have some tests within hir-expand that strictly only test the expansion parts. It feels wrong to me that they all live within hir-def (this also means we cant easily test a subset of r-a swapped to the new salsa for macro expansion if we wanted ;)
Kind of a funny stance as that goes directly against https://github.com/rust-lang/rust-analyzer/pull/10494 😬 I don't fully disagree, but I t think the issue at hand is more that we just have to little tests for macros. Some would make more sense within hir-def, some more in hir-expand.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.