rust-lang / rust-lang/rust-analyzer
Assists which always generate a snippet regardless of snippet capability
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
These assists always generate a snippet regardless of if the LSP client does or doesn't support the snippet text edit capability:
-
extract_expressions_from_format_stringhttps://github.com/rust-lang/rust-analyzer/pull/17333 -
generate_constant -
generate_mut_trait_implhttps://github.com/rust-lang/rust-analyzer/pull/20336
They unfortunately weren't captured in the initial batch of migrations to the new structured snippet API as they didn't use {insert,replace}_snippet, which is what I used to figure out which assists needed migrating.
Note that because the structured snippet API (add_{tabstop,placeholder}_*) relies on syntax nodes, they must also be migrated away from using insert and replace.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with crates/ide-assists/src/handlers/generate_constant.rs and compare it with assists already migrated to the structured snippet API. Check how snippet capability is handled, and identify the existing insert/replace usage that must be migrated. Done means generate_constant respects the LSP client's snippet support without relying on the old insertion methods.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100