rust-lang / rust-lang/rust-analyzer
Quickfix for `elided_lifetimes_in_paths` warning
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
1. hidden lifetime parameters in types are deprecated
`#[warn(elided_lifetimes_in_paths)]` implied by `#[warn(rust_2018_idioms)]` [elided_lifetimes_in_paths]
2. indicate the anonymous lifetime: `<'_>` [elided_lifetimes_in_paths]
I see the hint as part of the diagnostics but there is no code action to automatically add that. I also have a keybinding defined to instantly apply a code action with the quickfix kind according to the lsp protocol so it would be best if this assist was a quickfix.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing rust-analyzer's handling of Rust compiler diagnostics and its existing code-action or assist implementations, then inspect how LSP quickfix kinds are assigned. The change is complete when the elided_lifetimes_in_paths diagnostic offers a quickfix that inserts <'_> and can be applied through a quickfix keybinding; verify it with the relevant diagnostic and code-action tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100