rust-lang / rust-lang/rust-analyzer

"Fill struct fields" assist has stopped showing up in many cases

Open
#17,048 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-bug
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

rust-analyzer version: 0.3.1916-standalone

rustc version: rustc 1.77.1 (7cf61ebde 2024-03-27)

editor or extension: VS Code

relevant settings:

"rust-analyzer.hover.documentation.keywords.enable": false,
"rust-analyzer.cargo.buildScripts.useRustcWrapper": false,
"rust-analyzer.workspace.symbol.search.kind": "all_symbols",
"rust-analyzer.diagnostics.enable": false,
"rust-analyzer.inlayHints.closureStyle": "rust_analyzer",
"rust-analyzer.cargo.sysrootQueryMetadata": true,

screenshot_24-04-10_22:17:50

This is not the first time I've seen this happen, but this time it isn't happening in a macro (which I understand are difficult to handle in IDEs), and I see no other reason why "fill struct fields" shouldn't show up here. I've written wgpu::BindGroupLayoutEntry { } and while field completions work, there is no option to fill all missing fields like there used to.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in VS Code using wgpu::BindGroupLayoutEntry { } with rust-analyzer 0.3.1916 and check whether field completions appear without the "fill struct fields" assist. Trace the completion path for this assist and add a regression test for the reported case; done means the assist appears and fills all missing fields.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.