rust-lang / rust-lang/rust-analyzer
`MacroCallLoc` and `MacroDefId` should live in the `span` crate
Open
Nobody has claimed this yet.
A-hygiene
C-enhancement
E-unknown
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
These are effectively our version of rustc's HygieneData and we'll need them in the MBE crate to resolve hygiene. The problem with that is that we currently store Subtrees in MacroCallLoc which can't and should not be part of the span crate for obvious reasons (and they should not be in MacroCallLoc in the first place).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating MacroCallLoc and MacroDefId in the span crate and reviewing how MacroCallLoc currently stores Subtree values. Then inspect the MBE crate's hygiene-resolution entry points and existing tests; done means the types are usable from MBE without making Subtree part of span.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100