rust-lang / rust-lang/rust-analyzer

Feature request: Generate function assist should use Self alias

Open
#16,887 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-feature
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

When you have some code like

struct MyStruct {}

fn main() {
    let foo = MyStruct::from_list(&[0u32]);
}

And use the "generate function" assist on from_list, RA currently generates a function from_list with a signature like fn from_list(value: &[u32]) -> MyStruct in an impl block when it could also generate fn from_list(value: &[u32]) -> Self. I think the latter is generally preferred.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the generate-function assist implementation and its tests, then trace how the return type is chosen for functions generated in an impl block. Update the behavior so this case uses Self instead of the concrete struct name, and add or adjust coverage for the example; done means the assist produces the requested signature without regressing other generated functions.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.