rust-lang / rust-lang/rust-analyzer

Properly implement `builtin#offset_of`

Open
#16,872 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-ide A-parser C-feature
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

We already have the rough parts implemented, but our parse seems to be wrong and the IDE layer needs some help figuring out the syntax as stuff like std::mem::offset_of!(Option<&u8>, Some.0);/builtin#offset_of(Option<&u8>, Some.0); currently errors with parse errors and Some being unresolved.

The macro for this stabilizes in 3 days so

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the existing builtin#offset_of parsing and IDE-layer handling, then reproduce the parse errors with the two offset_of examples in the issue. Done means both forms parse correctly and Some is resolved rather than reported as unresolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers, devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.