rust-lang / rust-lang/rust-analyzer
Discarding json ptr deserialization for `config::Config`
Open
Nobody has claimed this yet.
A-config
C-enhancement
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
Haven't looked at the split between local global and client yet. Will do that later. Additionally, one thing for a follow up we should look at is whether we can discard the json ptr deserialization approach now that the config structure is fully typed.
Originally posted by @Veykril in https://github.com/rust-lang/rust-analyzer/issues/16639#issuecomment-1966281413
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the referenced discussion in rust-analyzer issue #16639 and locate the config::Config implementation and its JSON pointer deserialization path. Determine whether the fully typed config structure makes that approach removable; done means the replacement scope and any required validation are established, with no linked files or tests named in this issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100