rust-lang / rust-lang/rust-analyzer

Improve completions when an `enum`-variant is expected

Open
#16,760 6 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-completion C-feature
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

This case:

image

Should preferably suggest Self::NonTrivial(..) first/as one of the first suggestions.

This case:

image

Should suggest the variants first/should be included in the first suggestions.

In this case:

image

It's at least debatable whether the enum variants shouldn't be first in the list.

Maybe related Issues:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the three enum-completion examples in the issue and compare the current suggestion ordering. Trace rust-analyzer's completion ranking and enum-variant handling, then add focused regression coverage for the expected ordering and verify the related cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.