rust-lang / rust-lang/rust-analyzer
On unclosed `impl`, documentSymbol symbol name can span many lines
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
I'm not sure if there's anything to do here but I found this interesting.
No minimal reproducer but it should be reproducible on any impl block like below.
Cursor is at |
impl Foo<|
impl Bar<Baz> for Baz {
...
}
Now textDocument/documentSymbol will report a symbol with a name that starts at
impl Foo and spans across the impl Bar block and even further (in my case,
another impl block and a global function). I think it would be more intuitive to not report a symbol, or give it the name impl Foo<.
As workaround I'll truncate symbol names after the first line for now
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the textDocument/documentSymbol handling and reproduce the issue using the unclosed impl example in the report. Trace how the symbol name is formed across subsequent impl blocks and the global function; done means the reported symbol no longer spans unrelated lines, or is omitted as suggested.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100