rust-lang / rust-lang/rust-analyzer

Type annotations "look through" typedefs, which can be confusing.

Open
#1,666 28 comments 46 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-ty E-unknown S-unactionable
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

blah.rs:

pub struct Foo;

lib.rs:

mod blah;
type BlahFoo = blah::Foo;
pub struct Foo {
    inner: BlahFoo,
}
pub fn f(f: Foo) {
    let _x = f.inner;
}

Rust-analyzer reports the type of _x to be Foo, which is quite confusing -- it would be better as BlahFoo or even blah::Foo

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the example using blah.rs and lib.rs, then trace the type-display or annotation path that reports _x as Foo. The issue is done when the reported type preserves the typedef, such as BlahFoo or blah::Foo, instead of the underlying Foo.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.