rust-lang / rust-lang/rust-analyzer

False-positive diagnostics in regular code of a large codebase

Open
#16,513 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-bug
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

rust-analyzer version: rust-analyzer version: 0.4.1834-standalone (c48f14553 2024-02-07)
rustc version: rustc 1.75.0 (82e1608df 2023-12-21)

Open Zed, wait for r-a to load it and produce diagnostics in this file:
https://github.com/zed-industries/zed/blob/bde509fa749da60beb4ac378afd3ade15297bb91/crates/project/src/project.rs#L580

Expected: zero warnings/errors, same as cargo check --workspace --all-targets outputs
Actual: node and fs are labeled as "unused variables" but are used a few lines below, 2 more "errors" are also false-positive

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the diagnostics in Zed's crates/project/src/project.rs at the referenced location using the reported rust-analyzer and rustc versions. Compare the editor diagnostics for node, fs, and the other reported errors with cargo check --workspace --all-targets; done means the false-positive diagnostics no longer appear.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.