rust-lang / rust-lang/rust-analyzer
Renaming local variables is confused by attributes
Open
Nobody has claimed this yet.
A-proc-macro
C-bug
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
struct MyStruct {
foo: String, // rename me
}
#[tracing::instrument(skip_all)]
fn takes_mystruct(mystruct: MyStruct) {
let MyStruct { foo } = mystruct;
let value_of_foo = foo;
}
Renaming produces:
struct MyStruct {
bar: String, // rename me
}
#[tracing::instrument(skip_all)]
fn takes_mystruct(mystruct: MyStruct) {
let MyStruct { bar } = mystruct;
let value_of_foo = foo;
}
rust-analyzer version: 2024-01-01
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the supplied Rust reproduction and trace rust-analyzer's rename operation for the destructured field. Done means renaming the field updates the intended references without leaving value_of_foo = foo unresolved; add a regression test in the relevant test area once located.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100