rust-lang / rust-lang/rust-analyzer

Replace `in-rust-tree` feature flag with a cfg

Open
#16,320 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-infra A-rustc E-unknown
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

A feature flag infests all the cargo toml files unnecessarily, we should change that. Should be done in the rust-lang/rust repo though to minimize sync troubles.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the rust-lang/rust repository by locating the in-rust-tree feature flag and its uses across the Cargo TOML files. Trace how the corresponding cfg is currently represented and identify the changes needed to remove the feature flag without creating sync troubles. Done means the unnecessary Cargo feature flag is replaced by a cfg and the affected manifests remain consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.