rust-lang / rust-lang/rust-analyzer
'inline function' assist does not take generic type parameters into account when inlining an `into` call
Open
Nobody has claimed this yet.
A-assists
A-ty
C-bug
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
rust-analyzer version: 0.4.1765-standalone
rustc version: rustc 1.74.0 (79e9716c9 2023-11-13)
relevant settings: None
before:
let a: u16 = 123;
let b: i32 = a.into();
after (actual):
let a: u16 = 123;
let b: i32 = U::from(a);
after (expected):
let a: u16 = 123;
let b: i32 = i32::from(a);
The U does not get correctly replaced with the target type, in this case i32
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the inline function assist entry point and reproduce the reported Rust snippet using an into call with generic type parameters. Trace how the target type is substituted in the generated from call; done means the assist produces i32::from(a) rather than U::from(a).
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- developer-experience
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100