rust-lang / rust-lang/rust-analyzer

`Remove all the unused imports` removes aliased items

Open
#15,605 2 comments 9 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-assists C-bug
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

Path as PathExtract is being removed, although PathExtract is being used.
path::Path as StdPath is being removed, although StdPath is being used.

rust-analyzer version: rust-analyzer version: 0.3.1657-standalone (326f37ef1 2023-09-10)

rustc version: rustc 1.72.0 (5680fa18f 2023-08-23)

relevant settings: Not relevant(?)

Related: #15413

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the unused-import removal logic and reproduce the two reported cases: Path as PathExtract and path::Path as StdPath, where the aliases are used. Add a regression test showing that used aliased imports are retained, then verify the cleanup no longer removes them.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.