Merge `check.InvocationLocation` and `cargo.buildScripts.invocationLocation` configs into `cargo.InvocationLocation` config

Open
#15,493 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
devtools

Research direction

Start by locating the definitions and uses of check.InvocationLocation, cargo.buildScripts.invocationLocation, and cargo.InvocationLocation, then trace cargo metadata and cfg-querying invocations. Done means one cargo.InvocationLocation setting controls all cargo commands, including those currently run in the manifest directory.

Written by the indexing model from the issue text.

Description

A-config C-enhancement

There should never be a reason for these two to diverge, additionally, as soon as a project changes invocationLocation we should be running all cargo commands there. Currently we run cargo metadata in the manifest dir unconditionally, likewise the cfg querying invocations etc, whereas we should honor the setting for these as well.

See https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/rust-analyzer.20and.20compiler.2Frustc_codegen_cranelift/near/386334242

Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 13h
Merged PRs (30d)
69

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rust-lang/rust-analyzer

All issues in rust-lang/rust-analyzer

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.