rust-lang / rust-lang/rust-analyzer

Diagnostic quickfix: "add derive `Clone`/`Default`" if no method `clone`/`default` found in current scope

Open
#15,285 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-assists A-diagnostics C-feature
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

struct A;

fn main() {
    let a = A;
    a.$0clone();
}

or

struct B;

fn main() {
    B::$0default();
}

this currently suggests "generate clone method"/"generate default function" but I think in most cases the user would prefer to add #[derive(Clone)]/#[derive(Default)] to the struct/enum (unless the struct/enum cannot derive Clone/Default).

if this is okay, I would like to try implementing this.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the existing diagnostic quickfix implementation for unresolved clone and default calls in rust-analyzer, then trace how the current method or function suggestions are selected. Confirm how the surrounding struct or enum is identified, and consider the work complete when the relevant cases suggest #[derive(Clone)] or #[derive(Default)] instead where derivation is appropriate.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.