rust-lang / rust-lang/rust-analyzer

Rename symbol fails with `macro_rules!` chosen by `#[cfg(...)]`

Open
#15,193 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-bug
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

rust-analyzer version: rust-analyzer version: 0.3.1566-standalone
rustc version: rustc 1.70.0 (90c541806 2023-05-31)

Right-clicking the_macro under #[cfg(not(some_cfg_option))], choosing Rename symbol, and entering a new symbol name does not change the symbol name under #[cfg(some_cfg_option)].

Right-clicking the_macro under #[cfg(some_cfg_option)] and choosing Rename symbol fails with No references found at position.

#[cfg(not(some_cfg_option))]
macro_rules! the_macro {
    () => {};
}

#[cfg(some_cfg_option)]
macro_rules! the_macro {
    () => {};
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the provided cfg/macro_rules! reproduction and the Rename symbol entry point. Trace how the two cfg-selected definitions are resolved, then verify the behavior for renaming from either configuration; done means both macro names update without a “No references found at position” error.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.