rust-lang / rust-lang/rust-analyzer
`Fill match arms` duplicates arm with imported variants
Open
Nobody has claimed this yet.
A-assists
A-pattern
C-bug
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
Spotted in #15143.
ProjectionElem::Field(f) => match &base.data(Interner).kind {
TyKind::Adt(_, subst) => {
db.field_types(f.parent)[f.local_id].clone().substitute(Interner, subst)
}
chalk_ir::TyKind::Adt(_, _) => todo!(),
// ...
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the shown Fill match arms example involving ProjectionElem::Field and imported TyKind::Adt variants. Trace the match-arm filling implementation from that behavior; done when imported variants no longer produce a duplicate arm while the existing arm remains available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100