rust-lang / rust-lang/rust-analyzer
Go To Def doesn't go into `include!`d file if the definition is from an inner macro
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
main.rs:
fn main() {
T$0;
}
include!("includeme.rs");
includeme.rs:
macro_rules! m {
() => {
pub struct T;
};
}
m!();
Invoking Go To Def here takes you only to the include! invocation, not the m!() invocation inside the included file
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the provided main.rs and includeme.rs files, then start by tracing Go To Definition through the include! and inner macro expansion paths. Done means invoking Go To Definition on T reaches the m!() invocation in includeme.rs rather than stopping at the include! call.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100