rust-lang / rust-lang/rust-analyzer

Diagnose unbalanced delimiters

Open
#14,627 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-diagnostics C-feature
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

Rust has great diagnostics for unbalanced delimiters, it is shame r-a has NOTHING for them at all. We should fix that, it is invaluable to immediately see the problem when typing, copying or refactoring introduce unbalanced delims.

For:

(
    (
        [

    )
)

rustc produces

Compiling playground v0.0.1 (/playground)
error: mismatched closing delimiter: `)`
 --> src/main.rs:4:9
  |
3 |     (
  |     - closing delimiter possibly meant for this
4 |         [
  |         ^ unclosed delimiter
5 |
6 |     )
  |     ^ mismatched closing delimiter

error: could not compile `playground` (bin "playground") due to previous error 

meanwhile r-a just screams:
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the unbalanced-delimiter example in rust-analyzer and compare its diagnostics with the rustc output shown in the issue. Trace the diagnostic path for malformed delimiter nesting, then identify the relevant tests or entry points; done means the example reports the unclosed and mismatched delimiters with useful locations.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.