rust-lang / rust-lang/rust-analyzer
inline variable assist should take autoderef into account
Open
Nobody has claimed this yet.
A-assists
C-enhancement
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
fn main() {
let x = &[0][..];
x.len();
}
Inlining x here yields
fn main() {
(&[0][..]).len();
}
the parentheses are unnecessary though (technically the slicing as well since there is an unsizing step involved here)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names the inline variable assist but no file or test path; start by locating that assist's entry point and reproducing the Rust example. Done means inlining x accounts for autoderef and avoids the unnecessary parentheses, while considering whether the slicing can also be removed as described.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100