rust-lang / rust-lang/rust-analyzer

Don't run initial flycheck when workspace loading failed

Open
#14,453 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-flycheck C-bug
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

When the user changes their cargo toml causing us to reload the workspace with a failure we currently kick of cargo check which will immediately fail. We shouldn't attempt this!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the workspace reload path after a Cargo.toml change and the trigger for the initial flycheck run. Reproduce a failed workspace load, then verify that cargo check is not started in that case.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.