rust-lang / rust-lang/rust-analyzer

Qualify quick fix for out of scope trait replaces macro annotation

Open
#14,411 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-assists A-macro C-bug
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

The macro annotation is replaced when I click the Qualify quick fix for an out of scope trait:

https://user-images.githubusercontent.com/125105/227751573-8772e973-a94b-481e-ac17-3cdf24994490.mp4

rust-analyzer version:rust-analyzer version: 0.3.1443-standalone (825833c26 2023-03-19)

rustc version: rustc 1.68.0 (2c8cc3432 2023-03-06) (built from a source tarball)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the behavior shown in the linked video: use the Qualify quick fix for an out-of-scope trait and check whether the macro annotation is replaced. Trace the quick-fix handling for this case and verify that applying the fix preserves the macro annotation while qualifying the trait.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.