rust-lang / rust-lang/rust-analyzer

Assists that should really be diagnostics quickfix

Open
#14,262 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-assists A-diagnostics C-tracking-issue
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

We have a few assists that actually take the role of quickfixes of diagnostics, but haven't been implemented as such because of simplicity or due to us not having the diagnostic infra for it yet. We should make an effort into implementing the corresponding diagnostics and transitioning them towards becoming quickfixes for said diagnostics where applicable.

The following assists should be turned into quickfixes for diagnostics (fully or partially):

The assist checkbox is for when the assist code has been turned into the diagnostics quickfix

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the listed handlers under crates/ide-assists/src/handlers and compare them with the implemented diagnostics in crates/ide-diagnostics/src/handlers/missing_match_arms.rs and unresolved_method.rs. Work through the checklist, preserving assists where the issue notes they remain useful, and consider each item done when its applicable diagnostic quickfix is implemented and the checklist can be updated.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
developer-experience, devtools, tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.