rust-lang / rust-lang/rust-analyzer
Improve VSCode env var config substitution
Open
Nobody has claimed this yet.
A-config
A-vscode
C-enhancement
S-actionable
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
We currently only substitute ${env:ENV_VAR} in the env specific configs, ideally we should substitute these in the configs passed to the server in general.
Relevant code/FIXME https://github.com/rust-lang/rust-analyzer/blob/f1b257f4eb4fef74b42fd7135d1cf3884e8b51c9/editors/code/src/config.ts#L275
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in editors/code/src/config.ts at the referenced FIXME around line 275. Trace how ${env:ENV_VAR} substitution currently works for env-specific configs and identify the broader configs passed to the server. Done means environment-variable substitutions are applied to those general server configs as well.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust, vscode
- Domain
- developer-experience, tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100