rust-lang / rust-lang/rust-analyzer
references displayed inline can be confusing wrt compiler errors due to missing references
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
rust-analyzer version: v0.4.1314
rustc version: rustc 1.68.0-nightly (dfe3fe710 2022-12-09)
Sometimes RA when I pass a Ty into a function that takes a &Ty, RA will show the argument as &Ty but at the same time, rust will issue an error because "argument incorrect, consider borrowing here: &Ty" but it RA makes it look like the & was already there which can be confusing. I'm not sure if I have any better ideas, it might also that this looks completely different to other people with other settings (ra settings /syntax highlighting?)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported case in rust-analyzer v0.4.1314 with rustc 1.68.0-nightly: pass a Ty to a function taking &Ty and compare the inline reference display with the compiler's borrowing diagnostic. Use the linked troubleshooting guide and screenshot as context; done means the inline display no longer makes the missing borrow confusing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100