rust-lang / rust-lang/rust-analyzer
Request retrying needs to update file offsets in the tried requests
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
When a document change notification comes in, we currently cancel all outstanding requests and retry them after we changed the document, this obviously causes a problem: Offsets in those requests are now out of sync with the document which can cause a variety of odd issues (and panics). We need to fix them up before retrying again.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace the document change notification handling and the code that cancels and retries outstanding requests. Inspect how those requests retain file offsets, then verify that offsets are corrected after the document changes and before retrying, without causing the reported odd issues or panics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100