rust-lang / rust-lang/rust-analyzer
"Unwrap `Result` return type" shouldn't trigger in trait impls
Open
Nobody has claimed this yet.
A-assists
C-bug
S-actionable
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
trait Tr {
fn f() -> Result<(), ()>;
}
impl Tr for () {
fn f() -> $0Result<(), ()> {
todo!()
}
}
This offers the "Unwrap Result return type", which removes the return type here, but this is wrong in a trait impl if the trait isn't also modified (which requires fixing up every impl of it).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the "Unwrap Result return type" assist and reproduce the trait and impl example from the issue. Trace how the assist determines whether it can remove the return type, then verify that it is not offered in the trait implementation unless the trait declaration is also safely updated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100