rust-lang / rust-lang/rust-analyzer
Flyimport completions filter out re-exported crate roots
Open
Nobody has claimed this yet.
A-completion
C-bug
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
The following test should yield a result for configs, but configs is a crate root and therefor has no module name causing it to be filtered out.
#[test]
fn flyimport_crate_root() {
check(
r#"
//- /main.rs crate:main deps:commons
conf$0
//- /commons.rs crate:commons deps:configs
pub use configs;
//- /configs.rs crate:configs
pub struct XyConfig;
"#,
expect![""],
);
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Find the flyimport completion test containing flyimport_crate_root and run it to reproduce the empty expectation. Trace the filtering of the re-exported configs crate root, then update the behavior and test so the completion produces a result for configs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100