rust-lang / rust-lang/rust-analyzer
"Extract into function" misses format string captures
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
rust-analyzer version: rust-analyzer version: 0.4.1237-standalone (61504c8d9 2022-10-08)
rustc version: rustc 1.64.0 (a55dd71d5 2022-09-19)
Start with:
pub fn tester() {
let x = "hello";
let y = "world";
println!("{x} {}", y);
}
Run “Extract into function” on the println!. This produces:
pub fn tester() {
let x = "hello";
let y = "world";
fun_name(y);
}
fn fun_name(y: &str) {
println!("{x} {}", y);
}
Note that x does not become a parameter to the function, even though it must.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in rust-analyzer using the provided Rust snippet and the “Extract into function” action. Trace how format-string captures are identified during extraction, then verify that the generated function includes x as a parameter and that the resulting code compiles; add regression coverage if the project’s existing tests expose this action.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 42/100