rust-lang / rust-lang/rust-analyzer

"Extract into function" misses format string captures

Open
#13,389 1 comment 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-assists C-bug
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

rust-analyzer version: rust-analyzer version: 0.4.1237-standalone (61504c8d9 2022-10-08)

rustc version: rustc 1.64.0 (a55dd71d5 2022-09-19)

Start with:

pub fn tester() {
    let x = "hello";
    let y = "world";

    println!("{x} {}", y);
}

Run “Extract into function” on the println!. This produces:

pub fn tester() {
    let x = "hello";
    let y = "world";

    fun_name(y);
}

fn fun_name(y: &str) {
    println!("{x} {}", y);
}

Note that x does not become a parameter to the function, even though it must.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in rust-analyzer using the provided Rust snippet and the “Extract into function” action. Trace how format-string captures are identified during extraction, then verify that the generated function includes x as a parameter and that the resulting code compiles; add regression coverage if the project’s existing tests expose this action.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.