rust-lang / rust-lang/rust-analyzer
completion.callable.snippets trigger parameterHints popup regardless of parameterHints.enabled flag
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
rust-analyzer version: 0.3.1221-standalone (73ab709b3 2022-09-24)
rustc version: rustc 1.64.0 (a55dd71d5 2022-09-19)
relevant settings: MacBook Pro M1, VSCode 1.71.2 (Universal)
Summary
In vscode when parameterHints is set to false (with "editor.parameterHints.enabled": false), the rust-analyzer.completion.callable.snippets will still trigger the paramerterHints popup on completion regardless of the parameterHints flag.
Steps to reproduce
In VSCode settings:
"editor.parameterHints.enabled": false"rust-analyzer.completion.callable.snippets" = "fill_arguments"(or "add_parentheses")
Actual
When performing an auto complete, the parentheses or arguments will be completed correctly, but the parameterHint popup will be shown, even if editor.parameterHints.enabled was set to false.
The only way to avoid the parameterHints popup is to set the ...callable.snippets = "none" but then we lose the nice rust-analyzer parentheses or arguments auto completed.
Expected
Have the rust-analyzer.completion.callable.snippets follow the vscode parameterHints when deciding to show the parameterHints popup (but still autocomplete the parentheses or arguments as configured)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in VSCode with editor.parameterHints.enabled set to false and rust-analyzer.completion.callable.snippets set to fill_arguments or add_parentheses. Trace the completion.callable.snippets handling and its parameter-hints interaction. Done means parentheses or arguments still autocomplete while the parameter-hints popup remains suppressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- developer-experience, devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100