rust-lang / rust-lang/rust-analyzer
Feature Request: `unused-import` assist should remove unnecessary braces if only one import remains in the group after running
Open
Nobody has claimed this yet.
C-enhancement
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
Let's say I have a situation like this:
use foo::bar::{baz, quxx};
^~~ unused import
If I use the "remove unused import" assist, I end up with
use foo::bar::{quux};
^~~~~^ remove unnecessary braces
So I have to trigger another assist immediately after removing the unused import, which is kinda silly.
It would be great if the unused import assist was smart enough to remove unnecessary braces here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by reproducing the Rust example and tracing the unused-import assist entry point; done means one assist removes the unused import and also removes braces when exactly one import remains in the group.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- developer-experience
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100